Skip to content

feat: use paymaster for all zk testnet chains #5358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: use paymaster for all zk testnet chains #5358

merged 2 commits into from
Nov 8, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Nov 8, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on enhancing the handling of zkSync chains by incorporating testnet checks and improving transaction management with paymaster data.

Detailed summary

  • In isZkSyncChain.ts, added support for chain ID 2741.
  • In thirdweb.server.ts:
    • Imported getChainMetadata.
    • Added logic to check if a chain is a testnet.
    • Integrated isZkSyncChain to conditionally use paymaster data for zkSync testnets.
    • Removed the previous specific handling for the 531050104 chain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 02273a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:29pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:29pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:29pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 8:29pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 8, 2024 09:50 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 8, 2024 09:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 8, 2024 09:50 Inactive
@joaquim-verges joaquim-verges marked this pull request as ready for review November 8, 2024 09:50
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 8, 2024
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Nov 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (c8ad066) to head (02273a3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5358      +/-   ##
==========================================
- Coverage   45.71%   45.70%   -0.01%     
==========================================
  Files        1070     1070              
  Lines       55670    55671       +1     
  Branches     4094     4081      -13     
==========================================
- Hits        25450    25446       -4     
- Misses      29531    29536       +5     
  Partials      689      689
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c8ad066
packages 40.85% <100.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts 82.75% <100.00%> (+0.61%) ⬆️

... and 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.05 KB (0%) 862 ms (0%) 210 ms (+127.05% 🔺) 1.1 s
thirdweb (cjs) 103.17 KB (0%) 2.1 s (0%) 253 ms (+17.88% 🔺) 2.4 s
thirdweb (minimal + tree-shaking) 4.86 KB (0%) 98 ms (0%) 33 ms (+75.57% 🔺) 130 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 62 ms (+1592.24% 🔺) 72 ms
thirdweb/react (minimal + tree-shaking) 17.58 KB (-0.09% 🔽) 352 ms (-0.09% 🔽) 155 ms (+1355.77% 🔺) 507 ms

@0xFirekeeper
Copy link
Member

0xFirekeeper commented Nov 8, 2024

fallback if pm not deployed/fails?

@joaquim-verges joaquim-verges force-pushed the feat_use_paymaster_for_all_zk_testnet_chains branch from afb8f77 to 02273a3 Compare November 8, 2024 20:21
@joaquim-verges joaquim-verges merged commit 60eec03 into main Nov 8, 2024
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the feat_use_paymaster_for_all_zk_testnet_chains branch November 8, 2024 20:59
@edwardysun
Copy link
Contributor

edwardysun commented Nov 9, 2024 •
edited
Loading

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xFirekeeper 0xFirekeeper 0xFirekeeper approved these changes

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joaquim-verges @0xFirekeeper @edwardysun